fix(transaction-controller): Return global ethQuery when !isMultichainEnabled#4390
Merged
legobeat merged 1 commit intoMetaMask:mainfrom Jun 10, 2024
Conversation
legobeat
changed the title
!isMultichainEnabled
3 tasks
dbrans
previously approved these changes
Jun 7, 2024
legobeat
force-pushed
the
fix-multichaintrackinghelper-use-global-when-no-multi
branch
from
5a05293 to
31b2ea0
Compare
legobeat
force-pushed
the
fix-multichaintrackinghelper-use-global-when-no-multi
branch
from
31b2ea0 to
a365586
Compare
Contributor
Author
|
(Conflict resolution) |
6 tasks
legobeat
force-pushed
the
fix-multichaintrackinghelper-use-global-when-no-multi
branch
from
a365586 to
5a311c5
Compare
Contributor
Contributor
Author
The existing test is here. See also the |
legobeat
force-pushed
the
fix-multichaintrackinghelper-use-global-when-no-multi
branch
3 times, most recently
from
48bcfb6 to
3f23743
Compare
Contributor
Author
|
The test-related changes have now been separated into #4391. This PR now contains the fix in isolation. |
dbrans
approved these changes
Jun 10, 2024
…eturn ethQuery for global provider when !isMultichainEnabled
legobeat
force-pushed
the
fix-multichaintrackinghelper-use-global-when-no-multi
branch
from
3f23743 to
bb80e40
Compare
legobeat
added a commit
that referenced
this pull request
Jun 11, 2024
legobeat
added a commit
that referenced
this pull request
Jun 11, 2024
legobeat
added a commit
that referenced
this pull request
Jun 11, 2024
legobeat
added a commit
that referenced
this pull request
Jun 11, 2024
legobeat
added a commit
that referenced
this pull request
Jun 12, 2024
legobeat
added a commit
to legobeat/metamask-controllers
that referenced
this pull request
Jun 12, 2024
legobeat
added a commit
that referenced
this pull request
Jun 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
There is a test stating that "
MultichainTrackingHelper.getEthQueryshould always returnethQueryfor global provider when !isMultichainEnabled`".It was not, but the test was passing anyway due to the mock being hardcoded to do so. This fixes that.
Also refactors tests to actually test for it(separately in #4391).(Aside: I'm not sure why there even is a distinction between "global provider" and "chain-specific providers" in the first place - seems like there should never be a reason for both to exist simultaneously?)Answer: This is transitory and the "global provider" us due to be refactored away.References
Related
Blocking
Changelog
@metamask/transaction-controllerMultichainTrackingHelper.getEthQuerynow returns globalethQuerywithChecklist